Find new versions by parsing json #249
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Keeping the current functionality, but just changing how the version numbers are found. Instead of issuing HEAD requests, parse https://go.dev/dl/?mode=json for available versions and compare with what we currently have in the repo. Signed-off-by: Alper Polat <gitperr@gmail.com>
SuperQ
reviewed
Feb 22, 2024
SuperQ
reviewed
Feb 22, 2024
`url` is now constant, no extra work for string replacing anymore. Signed-off-by: Alper Polat <gitperr@gmail.com>
|
Is checking maximum of 40 minor revisions okay? Last I took a look at Go releases, they had like 20 something minor revisions max. or do you have another suggestion? |
|
Does this need any other work, or is it good to merge? |
|
@SuperQ this could be merged if there is no need for more changes |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
@SuperQ one attempt at fixing: #216
This should keep the current functionality as far as my testing goes. Now just getting the versions from the said json file.
What do you think?